Call NetworkTableInstance.waitForListenerQueue() before close() - #54
Merged
Conversation
kcooney
force-pushed
the
kcooney/wait-for-listener-queue
branch
5 times, most recently
from
September 6, 2025 06:09
384b28d to
fc9bd06
Compare
kcooney
force-pushed
the
kcooney/wait-for-listener-queue
branch
from
September 6, 2025 06:22
84ac240 to
3fecbbe
Compare
kcooney
force-pushed
the
kcooney/wait-for-listener-queue
branch
from
September 6, 2025 19:10
4fba0b6 to
3a9b57d
Compare
kcooney
changed the base branch from
main
to
kcooney/test-results-use-logger
September 6, 2025 19:11
kcooney
force-pushed
the
kcooney/test-results-use-logger
branch
from
September 6, 2025 19:18
15df1ed to
b5116ad
Compare
kcooney
force-pushed
the
kcooney/wait-for-listener-queue
branch
from
September 6, 2025 19:19
3a9b57d to
dfe760a
Compare
kcooney
force-pushed
the
kcooney/test-results-use-logger
branch
from
September 19, 2025 01:37
b5116ad to
2a3b1e7
Compare
kcooney
force-pushed
the
kcooney/wait-for-listener-queue
branch
from
September 19, 2025 01:38
dfe760a to
e41280f
Compare
kcooney
force-pushed
the
kcooney/test-results-use-logger
branch
from
September 20, 2025 01:20
2a3b1e7 to
9ae86e0
Compare
kcooney
force-pushed
the
kcooney/wait-for-listener-queue
branch
from
September 20, 2025 01:23
e41280f to
e8e0e39
Compare
This works around a race condition where a listener registered by Preferences was called after the NetworkTableInstance was closed.
kcooney
force-pushed
the
kcooney/wait-for-listener-queue
branch
from
September 23, 2025 01:00
e8e0e39 to
b13cc4c
Compare
kcooney
changed the base branch from
kcooney/test-results-use-logger
to
main
September 23, 2025 01:30
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 24, 2025
This includes the following: - Prospect-Robotics/lib2813#54 - Prospect-Robotics/lib2813#55 - Prospect-Robotics/lib2813#56 - Prospect-Robotics/lib2813#58 - Prospect-Robotics/lib2813#60
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 24, 2025
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 24, 2025
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 25, 2025
This includes the following: - Prospect-Robotics/lib2813#54 - Prospect-Robotics/lib2813#55 - Prospect-Robotics/lib2813#56 - Prospect-Robotics/lib2813#58 - Prospect-Robotics/lib2813#59 - Prospect-Robotics/lib2813#60 Local changes: - Remove now-redundant overrides of `MotorSubsystem.getAppliedCurrent()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around a race condition where a listener registered by Preferences
was called after the NetworkTableInstance was closed.
Also call
NetworkTableInstance.startLocal()so thatnetworktables.jsonis not read.